Skip to content

HHH-14519 More informative error message for bad logical column name #3853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

HHH-14519 More informative error message for bad logical column name #3853

wants to merge 3 commits into from

Conversation

@karge-itestra
Copy link
Contributor

@karge-itestra karge-itestra commented Mar 21, 2021 •
edited by hibernate-github-bot bot
Loading

When a logical column name identifier cannot be created, there is only an error message that the "column name must not be null". In the case I experienced, the column name was in fact empty and not null, but the column identifier could not be found. This changes the error message to make the cause more clear and also give information about the context (table name, column name given)

https://hibernate.atlassian.net/browse/HHH-14519

@hibernate-github-bot
Copy link

hibernate-github-bot bot commented Nov 24, 2024 •
edited
Loading

Thanks for your pull request!

This pull request does not follow the contribution rules. Could you have a look?

❌ All commit messages should start with a JIRA issue key matching pattern HHH-\d+
    ↳ Offending commits: [696db95, 49d2fcc, dc00552, 2607c91, 8f0a9c0, 60148a7, 48c54bc, 0fc5972, 52e7d12, 3c7c6f3, 82815cc, 64272ba, beae63a, 8c2b960, 0b86f5a, 3094185, 3691ca7, ff428b6, 8353743, a900ace, 0be6e7d, e9147dd, 5a1d6f6, 81624b0, cc3b389, e924c27, fc3d629, 1b098eb]
❌ The PR title or body should list the keys of all JIRA issues mentioned in the commits
    ↳ Issue keys mentioned in commits but missing from the PR title or body: [HHH-14211, HHH-14921, HHH-14922, HHH-14948, HHH-14972, HHH-14979, HHH-14935, HHH-14988, HHH-14987, HHH-15002, HHH-14998, HHH-15018, HHH-15024, HHH-15026, HHH-15028, HHH-15031, HHH-15033, HHH-15032, HHH-15022, HHH-15036, HHH-15044, HHH-15014, HHH-15009, HHH-14985, HHH-15041, HHH-14932, HHH-15069, HHH-15082, HHH-15060, HHH-15084, HHH-15094, HHH-15090, HHH-14817, HHH-15097, HHH-15106, HHH-15105, HHH-15115, HHH-15113, HHH-14996, HHH-15119, HHH-15051, HHH-15067, HHH-15124, HHH-15118, HHH-13694, HHH-14487, HHH-15147, HHH-15146, HHH-14819, HHH-15196, HHH-15209, HHH-15141, HHH-15178, HHH-15142, HHH-15212, HHH-4384, HHH-15091, HHH-15274, HHH-15222, HHH-15134, HHH-15270, HHH-15265, HHH-15281, HHH-15325, HHH-7525, HHH-15218, HHH-15322, HHH-15425, HHH-15440, HHH-15100, HHH-15454, HHH-15359, HHH-15388, HHH-15451, HHH-15468, HHH-15466, HHH-15216, HHH-14943, HHH-15505, HHH-15508, HHH-15523, HHH-15520, HHH-15522, HHH-15538, HHH-15336, HHH-15045, HHH-15235, HHH-15555, HHH-15559, HHH-15554, HHH-15594, HHH-15561, HHH-15575, HHH-15639, HHH-15637, HHH-15585, HHH-15616, HHH-15634, HHH-15649, HHH-15662, HHH-15685, HHH-15690, HHH-13106, HHH-15693, HHH-15792, HHH-15618, HHH-16049, HHH-15665, HHH-14514, HHH-16177, HHH-13627, HHH-16378, HHH-16545, HHH-16609, HHH-14944, HHH-16892, HHH-16977, HHH-17295, HHH-18475]

› This message was automatically generated.

@gavinking gavinking changed the base branch from 5.6 to main November 24, 2024 20:23
@gavinking gavinking changed the base branch from main to 5.6 November 24, 2024 20:23
@gavinking gavinking mentioned this pull request Nov 24, 2024
Merged
@gavinking
Copy link
Member

gavinking commented Nov 24, 2024

Thanks! Since this PR is out of date, I redid it in #9324. I credited you in the commit message.

@gavinking gavinking closed this Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gavinking gavinking gavinking left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@karge-itestra @gavinking